Insert the correct address into the allocations map#179
Merged
SamTebbs33 merged 3 commits intodevelopfrom Jul 6, 2020
Merged
Conversation
DrDeano
reviewed
Jul 1, 2020
Member
DrDeano
left a comment
DrDeano
left a comment
There was a problem hiding this comment.
:) Could add a test for allocating same addresses like in the other PR
SamTebbs33
force-pushed
the
bugfix/vmm-correct-addr-in-allocations
branch
from
8d7f3e0 to
7a03540
Compare
Collaborator
Author
I've added a check for the correct address being in the map since duplicate address allocation was a side effect of that not happening properly. Let me know if I should change the approach. |
SamTebbs33
force-pushed
the
bugfix/vmm-correct-addr-in-allocations
branch
from
c2f63a0 to
febb6c7
Compare
SamTebbs33
added a commit
that referenced
this pull request
Jul 6, 2020
…locations Insert the correct address into the allocations map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #178