Replace buddy allocator with free list allocator#183
Merged
SamTebbs33 merged 1 commit intodevelopfrom Jul 14, 2020
Merged
Conversation
SamTebbs33
commented
Jul 11, 2020
DrDeano
reviewed
Jul 12, 2020
Member
DrDeano
left a comment
DrDeano
left a comment
There was a problem hiding this comment.
Looks very nice, maybe could rename the old one to old_heap.
Missing a few doc comments XD. Need to keep that consistency :)
Also you mix one line if's and multi line:
if (blah) statement and
if (blah)
statement
The ones that are used as assignments are fine, and ones that have break or continue I think are fine as one line, but the others could be multi line with {}
SamTebbs33
force-pushed
the
feature/free-list-allocator
branch
from
3958382 to
d73c92a
Compare
DrDeano
reviewed
Jul 12, 2020
DrDeano
approved these changes
Jul 14, 2020
Member
DrDeano
left a comment
DrDeano
left a comment
There was a problem hiding this comment.
One the tests pass, can wait to finally run the scheduler XD
SamTebbs33
force-pushed
the
feature/free-list-allocator
branch
2 times, most recently
from
b264d35 to
6c2559d
Compare
SamTebbs33
force-pushed
the
feature/free-list-allocator
branch
from
6c2559d to
6d4b3e9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a new allocator which uses a free list over a buddy system. Once this PR is done I will fully replace heap.zig with heap2.zig. Let me know if the design is unclear or if any of the code could be cleaned up since it is quite complex atm.