Skip to content

A comptime bitmap#188

Merged
DrDeano merged 1 commit intodevelopfrom
feature/comptime-bitmap
Jul 14, 2020
Merged

A comptime bitmap#188
DrDeano merged 1 commit intodevelopfrom
feature/comptime-bitmap

Conversation

@DrDeano
Copy link
Member

@DrDeano DrDeano commented Jul 13, 2020

This allows for a bitmap that doesn't need an allocator.

This allows for a bitmap that doesn't need an allocator.
@DrDeano DrDeano requested a review from SamTebbs33 July 13, 2020 22:50
Copy link
Collaborator

@SamTebbs33 SamTebbs33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's a use case for this and is there a way we could allow both bitmap types to share code to reduce the duplication?

@DrDeano
Copy link
Member Author

DrDeano commented Jul 14, 2020

So we could init a bitmap as a global, I would like to use it for the PIDs as there is no runtime length of the bitmap and is hard coded, so if there was no allocations, then I can remove the tasking init function.
I shall see if I can reduce duplicate code.

Copy link
Collaborator

@SamTebbs33 SamTebbs33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@DrDeano DrDeano merged commit 17f0892 into develop Jul 14, 2020
@DrDeano DrDeano deleted the feature/comptime-bitmap branch July 14, 2020 17:48
@SamTebbs33 SamTebbs33 mentioned this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants