rpi led and serial

[markfirmware]

zig build -Dtarget=aarch64-freestanding

Then copy rpi-sdcard.img to an unused sd card and insert in 3b+

Will flash rpi3b+ activity led quickly on exception. Pins 14/15 have serial tx/rx.

[SamTebbs33]

Good job on getting it working in hardware! You're not going to like me for requesting this but could you add doc comments above each function, struct, struct field and public variable? Documentation is important :) Have a look at src/kernel/filesystem/vfs.zig for inspiration.

[markfirmware]

Some of the comments can be resolved. @SamTebbs33

[SamTebbs33]

Other then the comments from my latest review, it looks like all that is needed is some documentation and comments in initSerial.

[markfirmware]

Other then the comments from my latest review, it looks like all that is needed is some documentation and comments in initSerial.

Yes including a few questions that you made that I have not yet answered.

[SamTebbs33]

Thanks for cleaning up the image creation code in build.zig 👍

[SamTebbs33]

Thanks for replacing the wget and bash 👍 Including the firmware files here means that we need to replicate their copyright notices in the README, but I can do that before finishing the port. I think there are still a few unresolved comments left then we can go ahead and merge.

[markfirmware]

I have added the initSerial comments and removed the now unnecessary assembly code for the led.

I am now starting the /// commentary.

[markfirmware]

@SamTebbs33 Please check 997d157 for satisfaction.

[SamTebbs33]

Thanks @markfirmware 👍. It's great to have your changes to make it work on real hardware!