Skip to content

Comments

Code to check the number of max_lambda to the size of transaction was revised.#7

Open
TakahiroYamada wants to merge 3 commits intoa-terada:masterfrom
TakahiroYamada:master
Open

Code to check the number of max_lambda to the size of transaction was revised.#7
TakahiroYamada wants to merge 3 commits intoa-terada:masterfrom
TakahiroYamada:master

Conversation

@TakahiroYamada
Copy link
Contributor

@TakahiroYamada TakahiroYamada commented Jul 14, 2023

Dear Developers of LAMP,

Hi Hello. I'm Takahiro Yamada in UCSD in USA.

There was an oddity in the calculation process of max_lambda that has been corrected.
The length of the transaction_list is the number of genes to target, and in the following code section (lamp.py, line 363 to 365), if extra TF-Gene relationships are mixed in the item file or the exp file, the max_lambda is intended to be modified with the total number of genes listed in the item file as the upper limit I believe.

# check the max lambda to the nuber of transactions
	if max_value > ( len(transaction_list)/2 ):
		max_value = len(transaction_list)/2

From this point of view, instead of setting max_lambda to one-half of the length of the transaction_list, I have modified it to assign the length of the transaction_list as it is (otherwise, if this condition is violated and the number of target genes is an odd number, an error will occur at line 60 of frequentPatterns.py).

I hope this code could improve LAMP.

Best.

Takahiro

@TakahiroYamada
Copy link
Contributor Author

Sorry. There was a slight error in my explanation.
The exact explanation was that the maximum number of TF and taget gene combinations is odd, and if this number is greater than twice the number of target genes listed in the item file (i.e., the length of the transaction_list), an error will occur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant