Code to check the number of max_lambda to the size of transaction was revised.#7
Open
TakahiroYamada wants to merge 3 commits intoa-terada:masterfrom
Open
Code to check the number of max_lambda to the size of transaction was revised.#7TakahiroYamada wants to merge 3 commits intoa-terada:masterfrom
TakahiroYamada wants to merge 3 commits intoa-terada:masterfrom
Conversation
Contributor
Author
|
Sorry. There was a slight error in my explanation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Developers of LAMP,
Hi Hello. I'm Takahiro Yamada in UCSD in USA.
There was an oddity in the calculation process of
max_lambdathat has been corrected.The length of the transaction_list is the number of genes to target, and in the following code section (lamp.py, line 363 to 365), if extra TF-Gene relationships are mixed in the item file or the exp file, the
max_lambdais intended to be modified with the total number of genes listed in the item file as the upper limit I believe.From this point of view, instead of setting
max_lambdato one-half of the length of the transaction_list, I have modified it to assign the length of the transaction_list as it is (otherwise, if this condition is violated and the number of target genes is an odd number, an error will occur at line 60 of frequentPatterns.py).I hope this code could improve LAMP.
Best.
Takahiro