ci: Update coverage workflow #362
Merged
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
ishymko
approved these changes
Mar 19, 2026
Member
|
(replaced |
Contributor
Author
|
FYI: The change looks to be working as expected: #363 (comment) |
ikubicki
pushed a commit
to ikubicki/a2a-js
that referenced
this pull request
Mar 19, 2026
# Description Modification to code coverage calculation workflow so that the comparison is made against target branch and not `main`. This is valuable when PR targets some epic branch. Comparing the coverage with `main` branch is not accurate if the epic branch already drifted from `main`. # IMPORTANT NOTE An attempt to test this change was done on a draft PR: a2aproject#363 but the coverage comment workflow is executed from the `main` branch and not from the branch checkout. This means that in order to properly test this functionality in action, it needs to reach `main` state. In case any issues occur, I will provide an update to this logic or revert back to the original state.
bartek-gralewicz
added a commit
that referenced
this pull request
Mar 20, 2026
# Description Applying the same code test coverage comparison changes as on the `main` branch: #362 .
bartek-gralewicz
added a commit
that referenced
this pull request
Mar 23, 2026
# Description Applying the same code test coverage comparison changes as on the `main` branch: #362 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modification to code coverage calculation workflow so that the comparison is made against target branch and not
main.This is valuable when PR targets some epic branch. Comparing the coverage with
mainbranch is not accurate if the epic branch already drifted frommain.IMPORTANT NOTE
An attempt to test this change was done on a draft PR: #363 but the coverage comment workflow is executed from the
mainbranch and not from the branch checkout. This means that in order to properly test this functionality in action, it needs to reachmainstate.In case any issues occur, I will provide an update to this logic or revert back to the original state.