Skip to content

feat: Add cache headers logic to the agent card handler#435

Merged
bartek-gralewicz merged 2 commits into
epic/1.0_breaking_changesfrom
bgralewicz/agent_card_caching_headers
Apr 29, 2026
Merged

feat: Add cache headers logic to the agent card handler#435
bartek-gralewicz merged 2 commits into
epic/1.0_breaking_changesfrom
bgralewicz/agent_card_caching_headers

Conversation

@bartek-gralewicz
Copy link
Copy Markdown
Contributor

Description

Added cache headers logic to the agent card handler. These changes reflect the spec section 8.6.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

🧪 Code Coverage

⬇️ Download Full Report

Base PR Delta
src/server/express/agent_card_handler.ts 94.44% 100% 🟢 +5.56%
Total 85.37% 85.46% 🟢 +0.09%

Generated by coverage-comment.yml

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements HTTP caching for the agentCardHandler in Express, introducing ETag generation and Cache-Control header support. It also includes a new test suite to verify caching behavior and conditional request handling. The review feedback suggests using the idiomatic req.fresh property in Express to handle conditional requests more robustly and in full compliance with the HTTP specification.

Comment thread src/server/express/agent_card_handler.ts Outdated
@bartek-gralewicz bartek-gralewicz marked this pull request as ready for review April 28, 2026 14:20
@bartek-gralewicz bartek-gralewicz requested a review from a team as a code owner April 28, 2026 14:20
@bartek-gralewicz bartek-gralewicz merged commit 955b52b into epic/1.0_breaking_changes Apr 29, 2026
9 checks passed
@bartek-gralewicz bartek-gralewicz deleted the bgralewicz/agent_card_caching_headers branch April 29, 2026 06:10
ishymko added a commit that referenced this pull request May 11, 2026
🤖 I have created a release *beep* *boop*
---

## 1.0.0-alpha.0 (2026-05-11)

See the [v0.3 -> v1.0-alpha.0 migration
guide](https://github.com/a2aproject/a2a-js/blob/v1.0.0-alpha.0/docs/migration-guide.md).

**Note**: Enabling backward compatibility with v0.3 is tracked in
[#452](#452).


### ⚠ BREAKING CHANGES

* Drop support for node 18
([#368](#368))
* Make ServerCallContext parameter mandatory across all places
([#405](#405))
* Remove JSON-RPC client
([#353](#353))
* Remove transport-specific exports
([#404](#404))
* Update codebase to use A2A 1.0.0 data model
([#375](#375))
* Remove A2AExpressApp
([#363](#363))

### Features

* Add A2A Version Header
([#422](#422))
([b5f3db7](b5f3db7))
* Add cache-headers logic to the agent card handler
([#435](#435))
([955b52b](955b52b))
* Add resource scoping
([#450](#450))
([c527086](c527086))
* Add support for custom authentication scheme and credentials in
auth-headers ([#430](#430))
([5a4389b](5a4389b))
* AgentCardSignature support
([#448](#448))
([4a41a8c](4a41a8c))
* Enforce events ordering
([#437](#437))
([157cf48](157cf48))
* Enriched Error Model
([#427](#427))
([c130778](c130778))
* Implement listTasks method
([#383](#383))
([7d4c472](7d4c472))
* Send current task as the first event after subscribing to it
([#418](#418))
([4bfcf5f](4bfcf5f))
* Support multi-tenancy
([#419](#419))
([1877877](1877877))

### Code Refactoring

* remove A2AExpressApp
([#363](#363))
([0b84728](0b84728))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: bartek-gralewicz <bgralewicz@google.com>
Co-authored-by: Ivan Shymko <ishymko@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants