-
Notifications
You must be signed in to change notification settings - Fork 337
fix: Fix reference to grpc.aio.ServicerContext
#237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mikeas1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on improving the type correctness and clarity of gRPC asynchronous servicer contexts within grpc_handler.py. By adding a previously missing import and updating several type annotations, the code now more accurately reflects the asynchronous nature of its gRPC interactions, enhancing static analysis and maintainability without introducing any behavioral changes to the application.
Highlights
- Type Annotation Correction: Updated type annotations for
ServicerContextparameters fromgrpc.ServicerContexttogrpc.aio.ServicerContextin methods likebuildwithinCallContextBuilderandDefaultCallContextBuilder, and inabort_context. This ensures correct typing for asynchronous gRPC operations. - Missing Import Added: Added the necessary
import grpc.aiostatement to support the corrected asynchronous gRPC type annotations, resolving a previous omission. - Code Style Refinement: Adjusted the import style for
AgentCardandTaskNotFoundErrorfroma2a.typesto a more concise single-line format.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes the type annotations for grpc.aio.ServicerContext in src/a2a/server/request_handlers/grpc_handler.py. The changes, including adding the grpc.aio import and updating the type hints in various method signatures, are accurate and necessary for correct static analysis in an async gRPC context. The PR is well-focused and effectively resolves the described issue. The code quality is good, and I have no recommendations for changes.
grpc.aio.ServicerContext
59d17a4 to
cd29a40
Compare
Should be able to catch issues like those fixed in #237
# Description Fix references in a2a/server/request_handlers/grpc_handler.py to grpc.aio.ServicerContext. The import for grpc.aio was missing and various functions incorrectly referenced grpc.ServicerContext. This is a backwards compatible change, it's just typing annotations for internal functions that were off. The actual code itself worked, as can be demonstrated by running the sample agent in a2aproject/a2a-samples/samples/python/agents/dice_agent_grpc.
🤖 I have created a release *beep* *boop* --- ## [0.2.10](v0.2.8...v0.2.10) (2025-06-30) ### ⚠ BREAKING CHANGES * Update to A2A Spec Version [0.2.5](https://github.com/a2aproject/A2A/releases/tag/v0.2.5) ([#197](#197)) ### Features * Add `append` and `last_chunk` to `add_artifact` method on `TaskUpdater` ([#186](#186)) ([8c6560f](8c6560f)) * add a2a routes to existing app ([#188](#188)) ([32fecc7](32fecc7)) * Add middleware to the client SDK ([#171](#171)) ([efaabd3](efaabd3)) * Add more task state management methods to TaskUpdater ([#208](#208)) ([2b3bf6d](2b3bf6d)) * raise error for tasks in terminal states ([#215](#215)) ([a0bf13b](a0bf13b)) ### Bug Fixes * `consume_all` doesn't catch `asyncio.TimeoutError` in python 3.10 ([#216](#216)) ([39307f1](39307f1)) * Append metadata and context id when processing TaskStatusUpdateE… ([#238](#238)) ([e106020](e106020)) * Fix reference to `grpc.aio.ServicerContext` ([#237](#237)) ([0c1987b](0c1987b)) * Fixes Short Circuit clause for context ID ([#236](#236)) ([a5509e6](a5509e6)) * Resolve `APIKeySecurityScheme` parsing failed ([#226](#226)) ([aa63b98](aa63b98)) * send notifications on message not streaming ([#219](#219)) ([91539d6](91539d6)), closes [#218](#218) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Holt Skinner <holtskinner@google.com>
Description
Fix references in
a2a/server/request_handlers/grpc_handler.pytogrpc.aio.ServicerContext. The import forgrpc.aiowas missing and various functions incorrectly referencedgrpc.ServicerContext.This is a backwards compatible change, it's just typing annotations for internal functions that were off. The actual code itself worked, as can be demonstrated by running the sample agent in
a2aproject/a2a-samples/samples/python/agents/dice_agent_grpc.