Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/a2a/server/events/event_consumer.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ async def consume_all(self) -> AsyncGenerator[Event]:
# python 3.12 and get a queue empty error on an open queue
if self.queue.is_closed():
break
except Exception as e:
logger.error(f'Stopping event consumption due to exception: {e}')
self._exception = e
continue

def agent_task_callback(self, agent_task: asyncio.Task[None]) -> None:
"""Callback to handle exceptions from the agent's execution task.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,9 @@ async def on_message_send(
raise ServerError(
InternalError(message='Task ID mismatch in agent response')
)

except Exception as e:
logger.error(f'Agent execution failed. Error: {e}')
raise
finally:
if interrupted:
# TODO: Track this disconnected cleanup task.
Expand Down
5 changes: 4 additions & 1 deletion src/a2a/server/tasks/task_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ async def save_task_event(
task.history = [task.status.message]
else:
task.history.append(task.status.message)

if event.metadata:
if not task.metadata:
task.metadata = {}
task.metadata.update(event.metadata)
task.status = event.status
else:
logger.debug('Appending artifact to task %s', task.id)
Expand Down
21 changes: 21 additions & 0 deletions tests/server/tasks/test_task_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,27 @@ async def test_save_task_event_artifact_update(
updated_task.artifacts = [new_artifact]
mock_task_store.save.assert_called_once_with(updated_task)

@pytest.mark.asyncio
async def test_save_task_event_metadata_update(
task_manager: TaskManager, mock_task_store: AsyncMock
) -> None:
"""Test saving an updated metadata for an existing task."""
initial_task = Task(**MINIMAL_TASK)
mock_task_store.get.return_value = initial_task
new_metadata = {"meta_key_test": "meta_value_test"}

event = TaskStatusUpdateEvent(
taskId=MINIMAL_TASK['id'],
contextId=MINIMAL_TASK['contextId'],
metadata=new_metadata,
status=TaskStatus(state=TaskState.working),
final=False,
)
await task_manager.save_task_event(event)

updated_task = mock_task_store.save.call_args.args[0]
assert updated_task.metadata == new_metadata


@pytest.mark.asyncio
async def test_ensure_task_existing(
Expand Down
Loading