Skip to content

Conversation

@holtskinner
Copy link
Member

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to gracefully deprecate the use of camelCase aliases for model attributes within the A2ABaseModel by introducing explicit DeprecationWarning messages. This change encourages developers to adopt the snake_case naming convention for attribute access and modification, improving code consistency and maintainability. Additionally, I've updated Pydantic configuration and refactored existing code to align with these naming standards.

Highlights

  • Deprecation Warning for camelCase Aliases: I've introduced DeprecationWarning messages in the __setattr__ and __getattr__ methods of A2ABaseModel. Now, any attempt to access or set model attributes using their camelCase alias will trigger a warning, guiding users towards the preferred snake_case naming convention. These warnings specify that camelCase alias support will be removed in version 0.3.0.
  • Pydantic Configuration Update: The model_config in A2ABaseModel has been updated to use populate_by_name=True instead of the deprecated validate_by_name and validate_by_alias settings. This aligns with Pydantic's recommended approach for handling field population and validation.
  • Internal Code Refactoring: I've refactored instances of taskId to task_id within src/a2a/server/request_handlers/default_request_handler.py and its corresponding tests. This change ensures consistency with the snake_case naming convention and prepares the codebase for the eventual removal of camelCase alias support.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a deprecation warning for using camelCase aliases, which is a great step towards standardizing on snake_case. The implementation is solid. My review includes a couple of suggestions to improve maintainability by reducing code duplication and to consistently apply the snake_case convention for all attributes to avoid future deprecation warnings.

@holtskinner holtskinner merged commit f22b384 into main Jul 21, 2025
8 checks passed
@holtskinner holtskinner deleted the camelcase-deprecation branch July 21, 2025 19:46
holtskinner pushed a commit that referenced this pull request Jul 21, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.2.16](v0.2.15...v0.2.16)
(2025-07-21)


### Features

* Convert fields in `types.py` to use `snake_case`
([#199](#199))
([0bb5563](0bb5563))


### Bug Fixes

* Add deprecation warning for camelCase alias
([#334](#334))
([f22b384](f22b384))
* client should not specify `taskId` if it doesn't exist
([#264](#264))
([97f1093](97f1093))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants