refactor: unify transport name constants usage#728
Conversation
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the handling of transport protocol constants by migrating from individual string constants to a unified Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
1bee382 to
d09a6a2
Compare
There was a problem hiding this comment.
Code Review
This pull request is a well-executed refactoring that unifies the usage of transport protocol constants into a TransportProtocol enum. This change significantly improves code clarity, maintainability, and type safety. The refactoring has been applied consistently across both the application logic and the test suite. I have one minor suggestion to improve the readability of a type hint, but overall, the changes are excellent.
6c22528 to
a278c4d
Compare
Use enum everywhere, data model uses
strfor protocol names, so custom protocols won't be constrained with the enum.Fixes #705