fix: do not use A2A context_id as ADK user#534
Merged
Conversation
The A2A `context_id` must never be used as the ADK `user_id`: it is client-supplied and a malicious caller that learns another user's `context_id` could otherwise hijack their ADK session state.
ishymko
changed the title
context_id as ADK user
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances security by resolving a stable user_id from the request context instead of relying on the client-supplied context_id for session management. These changes are implemented across both the adk_currency_agent and adk_skills_agent. Feedback was provided regarding the duplication of the ensure_session method and _resolve_user_id function, suggesting they be refactored into a shared utility or base class to adhere to DRY principles.
4 tasks
guglielmo-san
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The A2A
context_idmust never be used as the ADKuser_id: it is client-supplied and a malicious caller that learns another user'scontext_idcould otherwise hijack their ADK session state.