Skip to content

Comments

[3] – Use OAuth email filtering for global deployments#19

Open
dvjsharma wants to merge 2 commits intoa2i-code-For-Govstack:django-backendfrom
dvjsharma:feat/multipleOrgs
Open

[3] – Use OAuth email filtering for global deployments#19
dvjsharma wants to merge 2 commits intoa2i-code-For-Govstack:django-backendfrom
dvjsharma:feat/multipleOrgs

Conversation

@dvjsharma
Copy link

Description

This PR introduces a new feature for global deployment. Now instead configuring OAuth App, creators can provide a list of allowed domains and backend will filter unauthorised domains. Added the following:

  • A new allowed_domain list mapped to each instance.
  • Default config is to allow all domains (*).
  • Eliminated dependency to update the OAuth app.

How to test

  • Add only particular org domain in the allowed list.
  • Sign in using that domain, you will get a token.
  • Sign up with another domain, you will get an error.

Signed by Divij Sharma

CC @Sanchay-T

Signed-off-by: Divij Sharma <divijs75@gmail.com>
Signed-off-by: Divij Sharma <divijs75@gmail.com>
dvjsharma added a commit to dvjsharma/sp-service-solutions-api-Django that referenced this pull request Sep 18, 2024
feat(OAuth): Migrate state & code swap to backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant