InputValue KType #157
Merged
InputValue KType #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks okay. I will publish this in version Otherwise, I would love a failing unit test if something is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support generic input types discussed in #143, and overcome the jvm erasure issue discussed in #144, kType is added to inputValue.
The code does compile, tests do run, however, whenever I build and use it in my application, it does compile but I get java.lang.NoSuchMethodErrors when trying to invoke these altered methods.
I can't seem to figure out whether it's a caching issue on my side or something else.
Could you take a look?