Skip to content

Remove redundant .toString() call, use treeToValue instead of readValue #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeggy merged 1 commit into from
Jan 11, 2023
Merged

Remove redundant .toString() call, use treeToValue instead of readValue #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kgraphql/src/main/kotlin/com/apurebase/kgraphql/request/VariablesJson.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ interface VariablesJson {
require(kClass == kType.jvmErasure) { "kClass and KType must represent same class" }
return json.let { node -> node[key.value] }?.let { tree ->
try {
// Calling [toString] as a hack for now. TODO: Move away from jackson and only depend on kotlinx.serialization
objectMapper.readValue<T>(tree.toString(), kType.toTypeReference())
// TODO: Move away from jackson and only depend on kotlinx.serialization
objectMapper.treeToValue<T>(tree, kType.toTypeReference())
} catch(e : Exception) {
throw if (e is GraphQLError) e
else ExecutionException("Failed to coerce $tree as $kType", key, e)
Expand Down