Fix build and .gitignore #335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier changes (7f8efaa and 750fb33) broke the contract of site.java. The GitHub workflow was updated but the .gitignore and the Makefile were not. This resulted in not being able to build the project using make and if the project was built manually, generated files were not ignored. See aalmiray@7f8efaa See aalmiray@750fb33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier changes (7f8efaa and 750fb33) broke the contract of
site.java. The GitHub workflow was updated but the.gitignoreand theMakefilewere not. This resulted in not being able to build the project usingmakeand if the project was built manually, generated files were not ignored.