Update ocamlformat version #445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can we re-push the commit to re-trigger the CI for this? |
This fixes a problem where the project cannot be solved when `with-test` is true. It depended on ocamlformat.0.16.0 which in turn depends on ppxlib < 0.22, but this project also depends on ppxlib >= 0.28.0, so no solution was possible. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
update-ocamlformat
branch
from
9f57082 to
5a17b12
Compare
Author
|
I tried but it didn't fix the issue. I don't think it's related to my change. |
Contributor
|
Indeed, I just opened a PR to fix it: #449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where the project cannot be solved when
with-testis true. It depended on ocamlformat.0.16.0 which in turn depends on ppxlib < 0.22, but this project also depends on ppxlib >= 0.28.0, so no solution was possible.I came across this problem when trying to solve the project's dependencies with dune package management, which becomes possible after this change.