Conversation
|
320 File changed! 😦 Did you make a mistake in your commit history? Maybe you need a better gitignore file? |
Anasauce
reviewed
Feb 27, 2017
| } | ||
|
|
||
| maxOfThree = (num1, num2, num3) => { | ||
| let max |
There was a problem hiding this comment.
so you should decide between let and const or only use var
| translate = (str) => { | ||
| let vowels = ['A', 'a', 'E', 'e', 'I', 'i', 'O', 'o', 'U', 'u'] | ||
| let counter = 0 | ||
| for (let i = 1; i < str.length; i++) { |
There was a problem hiding this comment.
try challenging yourself to use a more complex function here like reduce() or map()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.