Conversation
added 12 commits
March 8, 2017 12:05
| DROP TABLE IF EXISTS friend; | ||
| CREATE TABLE friend ( | ||
| id1 INTEGER REFERENCES student(id), | ||
| id2 INTEGER REFERENCES student(id), |
There was a problem hiding this comment.
A clearer naming structure for a join table would be something like:
student_friends (includes a reference to the student table in the table name)
id (the primary key of the student)
friend_id (the primary key of another student)
It might seem a little redundant to differentiate between the two student ids, but it would allow you to select all of a student's friends using something like:
SELECT friend_id FROM student_friends WHERE id = (studentId)|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This much whitespace doesn't make it any clearer why you're breaking up the queries, so it isn't really helpful - A better way to separate them would be with a comment line to explain the difference, or by making 09-mutual-likes a directory and separating the queries into different sql files inside that directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.