Merged
Conversation
|
Is any one against merging this ? vote :) or :( on this comment |
|
Merge please, you amazing person 👍 |
|
Yes please! |
|
Open position for mac developers: |
Open
|
Please approve me as maintainer, then I will merge this change: Feel free to also apply: |
|
We use this PR internally. We would be glad if this gets merged. Thanks for your effort! |
|
Ok I assume it's ok to be merged, it will be easy to revert if any regression, Do you see other open patch upstream that can be merged before I made a release ? |
|
Replace: noble#790 |
|
May I suggest to add mac build to CI/CD |
|
Definitely a good idea! |
pfafman
pushed a commit
to pfafman/noble
that referenced
this pull request
Dec 30, 2024
Co-authored-by: Marek Serafin <marek.serafin@assaabloy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase noble#840 on this repo and add latest changes from Timeular/noble-mac
Fixes #4