Fix localizations

[ConfusedVorlon]

1.81 generates a warning when submitting to iTunes (re Unrecognized Locale -)
It looks like this is fixed in a more recent commit.

Could you push 1.82?

thank you.

[abbeycode]

Thanks for pointing this out. I didn't realize the issues I fixed would affect anything material. I'll work on this when I can (hopefully today).

[ConfusedVorlon]

thank you.

[ConfusedVorlon]

It is just a warning from iTunes, not an error, but would be nice to get
rid of it.

Thank you

---

Small phone. Terse response.

On 25 Oct 2016 3:46 pm, "Dov Frankel" notifications@github.com wrote:

Thanks for pointing this out. I didn't realize the issues I fixed would
affect anything material. I'll work on this when I can (hopefully today).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#42 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj0nsnXmqXJ6gkM57UzGWDWqJxS0AG3ks5q3hY7gaJpZM4Kf6YB
.

[abbeycode]

I've bumped the version, and pushed an update to CocoaPods. Thanks again for pointing this out!

[tomjpsun]

Hi ! 1.8.3 still gets this warning. Could you re-open the issue again ?

[abbeycode]

@tomjpsun Could you please give me more info, since I haven't seen that error?

1. How are you building UnzipKit (CocoaPods, Carthage, Directly embedded source)?
2. At what time are you receiving the error (build time, analyze time, submission to App Store)?
3. What exact error are you getting? Screenshot and copy-paste of text, if possible, would be great

Thanks!

[ConfusedVorlon]

Hi,

I'm building with cocoapods for a swift app using frameworks.

This is the error I get (it comes as an email after I upload an app to iTunes Connect)

Dear developer,

We have discovered one or more issues with your recent delivery for "Stmpr - Write your own gif!". Your delivery was successful, but you may wish to correct the following issues in your next delivery:

Unrecognized Locale -
The directory located at ( 'Payload/STMPR.app/Frameworks/UnzipKit.framework/UnzipKitResources.bundle/base.lproj' ) has an unrecognized locale name. Refer to the Language and Locale Designations guide for more information on naming your language-specific directories.

After you’ve corrected the issues, you can use Xcode or Application Loader to upload a new binary to iTunes Connect.

Regards,

The App Store team

Comparing unzipkit with other pods that don't generate an error; the format for unzipkit is

/UnzipKit.framework/UnzipKitResources.bundle/base.lproj'

wheras other frameworks have

/UnzipKit.framework/UnzipKitResources.bundle/en.lproj'

(and other languages - but not base)

I'm guessing something about putting this into the framework means that base isn't ok, and you need to provide explicit language folders.

There is a plist entry which describes the native localisation region as en; so I don't think there is any ambiguity as to the default language.

tl;dr; I think you you change base.lproj to en.lproj, then everything will be splendid!