Skip to content

Conversation

@pdewilde
Copy link
Contributor

@pdewilde pdewilde commented Nov 20, 2025

This should show up as a PWN request to the codeql scanner is it's checking out head sha in pull_request_target and executing.

In practice, this will never actually cause anything bad due to the if false in the script. (I also intend to revert this change in the next PR).

I want to validate that the status check is not currently required, which requires me merging something that fails it.

@pdewilde pdewilde requested a review from a team as a code owner November 20, 2025 21:08
@pdewilde pdewilde enabled auto-merge (squash) November 21, 2025 01:33
@pdewilde pdewilde requested a review from Laptop765 November 21, 2025 19:12
Copy link

@Laptop765 Laptop765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need sign off on this one or is it just for testing?

@pdewilde
Copy link
Contributor Author

Do you need sign off on this one or is it just for testing?

I want to sign off to ensure it can be merged with failing status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants