Corrections for PlasmaLinac.assemble_trackables() that calculates the linac nominal energy from the nominal energy gains of each plasma stage#174
Merged
ben-c-2013 merged 5 commits intomainfrom Dec 19, 2025
Conversation
… linac nominal energy from the nominal energy gains of each plasma stage.
kyrsjo
reviewed
Dec 19, 2025
kyrsjo
reviewed
Dec 19, 2025
kyrsjo
reviewed
Dec 19, 2025
Collaborator
|
Finally I understand, the only real change here is removing And doing the prints per-stage (however the prints of upramp/downramp is conflicting with #182). Merge #182 first, then merge back here and fix here. Then OK to merge. |
Collaborator
Author
Done in commit b90a61c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.