Bump llama_tokenize APIs to latest specs#730
Closed
manishshettym wants to merge 3 commits intoabetlen:mainfrom
Closed
Bump llama_tokenize APIs to latest specs#730manishshettym wants to merge 3 commits intoabetlen:mainfrom
manishshettym wants to merge 3 commits intoabetlen:mainfrom
Conversation
Author
|
Ref to the relevant change in llama.cpp's API (two days ago): ggml-org/llama.cpp#3170 |
Author
|
closing this PR since the changes were made directly by @abetlen! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
llama_tokenizeandllama_tokenize_with_modelAPIs are out-dated with respect to the equivalent APIs in llama.cpp (as shown below):ISSUE: Particularly, they are missing an argument
text_lenwhich denotes the length of the text/prompt being tokenized. This causes segmentation faults, as the wrong arguments get passed on to the C++ library.This PR adds the required arguments to llama_cpp.py. cc: @abetlen