Fix #777, #464#778
Closed
Freed-Wu wants to merge 1 commit intoabetlen:mainfrom
Freed-Wu:iss777
Closed
Conversation
ggml-org/llama.cpp#3424 Move some code about disabling some flags in Apple x86 to the upstream Use ExternalProjectAdd() to simplify CMakeLists.txt Change base_path from llama_cpp to llama_cpp/data like other projects: - https://github.com/ssciwr/clang-format-wheel/blob/99df0fe0145e0af14c38772f1af78b215456e3a3/CMakeLists.txt#L44 - https://github.com/Freed-Wu/astyle-wheel/blob/340cef6dfd5cfa9158a321fe01b36df6a1e826e8/CMakeLists.txt#L12 - https://github.com/scikit-build/cmake-python-distributions/blob/13473f41061f73e599987af8dee5ba262e065769/setup.py#L46 - https://github.com/scikit-build/ninja-python-distributions/blob/e5510f4f725323b9be845a023bdc164718df1ddd/CMakeLists.txt#L149
abetlen
force-pushed
the
main
branch
2 times, most recently
from
8c93cf8 to
cc0fe43
Compare
Author
|
@abetlen Any problem? Some conflicts have been occured. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ggml-org/llama.cpp#3424
Move some code about disabling some flags in Apple x86 to the upstream
Use ExternalProjectAdd() to simplify CMakeLists.txt
Change base_path from llama_cpp to llama_cpp/data like other projects: