Skip to content

Conversation

@zhaojiangbin
Copy link

If the variable `nodejs-repl-command' is a function symbol, call that function for the path to Node.js command.

This allows to integrate with Node.js version managers such as nvm.

Tested with nvm version 0.33.11 on macOS version 10.13.6, Emacs version 26.1.

@abicky abicky changed the base branch from master to develop September 15, 2018 04:38
@abicky abicky changed the base branch from develop to master September 15, 2018 04:40
@abicky
Copy link
Owner

abicky commented Sep 15, 2018

LGTM 👍
Could you change the branch to be merged to develop and rebase onto develop branch?

@zhaojiangbin zhaojiangbin changed the base branch from master to develop September 16, 2018 23:25
@zhaojiangbin
Copy link
Author

Could you change the branch to be merged to develop and rebase onto develop branch?

Done.

If the variable `nodejs-repl-command' is a function symbol, call the
function for the path.
@zhaojiangbin
Copy link
Author

Updated README.md to fix a typo.

@abicky abicky merged commit 5307232 into abicky:develop Sep 17, 2018
@abicky
Copy link
Owner

abicky commented Sep 17, 2018

Thank you for your contribution!

@zhaojiangbin zhaojiangbin deleted the nvm branch September 17, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants