Use packages in overrides directory#235
Merged
dantedelucia merged 1 commit intoAug 19, 2025
Merged
Conversation
alexanderguy
requested changes
Aug 13, 2025
Contributor
alexanderguy
left a comment
alexanderguy
left a comment
There was a problem hiding this comment.
Thanks for putting this up. I left some notes.
dantedelucia
force-pushed
the
kit-519-add-the-ability-to-use-a-directory-to-specify-deb-overrides
branch
from
f9e3c47 to
7f4c81d
Compare
alexanderguy
requested changes
Aug 15, 2025
dantedelucia
force-pushed
the
kit-519-add-the-ability-to-use-a-directory-to-specify-deb-overrides
branch
2 times, most recently
from
d8f0fae to
e1a3918
Compare
Contributor
alexanderguy
left a comment
alexanderguy
left a comment
There was a problem hiding this comment.
I left another round of notes. While you're in there, please add a unit test as well, so that you can double check all of your logic/how things are layered. Please make the test:
- Verify that packages that have explicitly overridden in
Overridearen't clobbered byOverrideDir. - What happens when the directory doesn't exist.
- Check for duplicate packages.
- It shouldn't error if a package isn't in the override directory.
dantedelucia
force-pushed
the
kit-519-add-the-ability-to-use-a-directory-to-specify-deb-overrides
branch
from
e1a3918 to
1472dcb
Compare
dantedelucia
force-pushed
the
kit-519-add-the-ability-to-use-a-directory-to-specify-deb-overrides
branch
3 times, most recently
from
f393e24 to
dc659f3
Compare
alexanderguy
requested changes
Aug 18, 2025
Contributor
alexanderguy
left a comment
alexanderguy
left a comment
There was a problem hiding this comment.
Thanks for putting that up. Much improved; just some notes.
dantedelucia
force-pushed
the
kit-519-add-the-ability-to-use-a-directory-to-specify-deb-overrides
branch
2 times, most recently
from
ecfb953 to
7e1154b
Compare
This allows you to specify a directory that contains local packages you wish to use, instead of the packages that are available from the apt repositories. These can be provided per SVMKit component, alongside the existing package override mechanism.
dantedelucia
force-pushed
the
kit-519-add-the-ability-to-use-a-directory-to-specify-deb-overrides
branch
from
7e1154b to
48d4e62
Compare
dantedelucia
deleted the
kit-519-add-the-ability-to-use-a-directory-to-specify-deb-overrides
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple override directory implementation. Not sure if we want to add it as an explicit config option.