Kit 546 figure out why frankendancer build script doesnt clean#237
Merged
dantedelucia merged 2 commits intoSep 16, 2025
Merged
Conversation
alexanderguy
requested changes
Sep 15, 2025
Contributor
alexanderguy
left a comment
alexanderguy
left a comment
There was a problem hiding this comment.
From the outside looking at the commit message "Recurse on sync and update" doesn't convey a lot of information. Would you please change it to "Make git submodule actions recursive for Firedancer build" or something similar?
dantedelucia
force-pushed
the
kit-546-figure-out-why-frankendancer-build-script-doesnt-clean
branch
from
5f91a30 to
c742b28
Compare
alexanderguy
approved these changes
Sep 15, 2025
dantedelucia
deleted the
kit-546-figure-out-why-frankendancer-build-script-doesnt-clean
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.