Skip to content

Check for free space on error#238

Merged
dantedelucia merged 2 commits into
mainfrom
kit-547-implement-check-to-determine-if-tmp-has-enough-free-space
Sep 18, 2025
Merged

Check for free space on error#238
dantedelucia merged 2 commits into
mainfrom
kit-547-implement-check-to-determine-if-tmp-has-enough-free-space

Conversation

@dantedelucia
Copy link
Copy Markdown
Contributor

I still seem to have a problem with the defer() overwriting the existing error. Very much an edge case for now.

@linear
Copy link
Copy Markdown

linear Bot commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

@alexanderguy alexanderguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach, I left some notes on the implementation.

Comment thread pkg/runner/deployer/ssh.go
Comment thread pkg/runner/deployer/ssh.go Outdated
Comment thread pkg/runner/deployer/ssh.go Outdated
Comment thread pkg/runner/deployer/ssh.go Outdated
Comment thread pkg/runner/deployer/ssh.go Outdated
Comment thread pkg/runner/deployer/ssh.go
@dantedelucia dantedelucia force-pushed the kit-547-implement-check-to-determine-if-tmp-has-enough-free-space branch 2 times, most recently from 955bf0e to d9a5472 Compare September 18, 2025 01:15
@dantedelucia dantedelucia force-pushed the kit-547-implement-check-to-determine-if-tmp-has-enough-free-space branch from d9a5472 to d05f56c Compare September 18, 2025 02:16
Copy link
Copy Markdown
Contributor

@alexanderguy alexanderguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pkg/runner/deployer/ssh.go
@dantedelucia dantedelucia merged commit a1bd460 into main Sep 18, 2025
1 check passed
@dantedelucia dantedelucia deleted the kit-547-implement-check-to-determine-if-tmp-has-enough-free-space branch September 18, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants