Skip to content

investigate culprit for why residualMembers can get into inconsistent state #877

@ikbalkaya

Description

@ikbalkaya

We should investigate why residualMembers can get into null when endSync is called.
Context :

Yes - you are right, I had a check and the access is protected. In this case, I think doing this might remedy crashing the app, but it means that we are probably covering up another important bug - As far as I can see the only place residualMembers is null can be null is where it's declared and in endSync method. In this case it means either endSync is invoked early (before startSync) or is invoked after another endSync which would be problematic. I will approve this to remedy the crash but I think we should create another issue to investigate this situation.

Originally posted by @ikbalkaya in #873 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working. It's clear that this does need to be fixed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions