-
Notifications
You must be signed in to change notification settings - Fork 42
Open
Labels
bugSomething isn't working. It's clear that this does need to be fixed.Something isn't working. It's clear that this does need to be fixed.
Description
We should investigate why residualMembers can get into null when endSync is called.
Context :
Yes - you are right, I had a check and the access is protected. In this case, I think doing this might remedy crashing the app, but it means that we are probably covering up another important bug - As far as I can see the only place
residualMembersis null can be null is where it's declared and inendSyncmethod. In this case it means eitherendSyncis invoked early (beforestartSync) or is invoked after anotherendSyncwhich would be problematic. I will approve this to remedy the crash but I think we should create another issue to investigate this situation.Originally posted by @ikbalkaya in #873 (comment)
Metadata
Metadata
Assignees
Labels
bugSomething isn't working. It's clear that this does need to be fixed.Something isn't working. It's clear that this does need to be fixed.