Skip to content

added null check to prevent NullPointerExceptions #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davyskiba merged 1 commit into from
Dec 7, 2022
Merged

added null check to prevent NullPointerExceptions #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/src/main/java/io/ably/lib/realtime/Presence.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,9 +1176,13 @@ synchronized List<PresenceMessage> endSync() {
/* any members that were present at the start of the sync,
* and have not been seen in sync, can be removed */
for(String itemKey: residualMembers) {
/* clone presence message as it still can be in the internal presence map */
removedEntries.add((PresenceMessage)members.get(itemKey).clone());
members.remove(itemKey);
PresenceMessage removedMember = members.remove(itemKey);
/* This null check is added as a potential fix for an issue that
* could not be reproduced, reported here https://github.com/ably/ably-java/issues/853 */
if(removedMember != null) {
/* clone presence message as it still can be in the internal presence map */
removedEntries.add((PresenceMessage) removedMember.clone());
}
}
residualMembers = null;

Expand Down