Skip to content

Update specs with comments to docs seciton for RSN3a/RSN3c #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owenpearson merged 1 commit into from
Oct 21, 2021
Merged

Update specs with comments to docs seciton for RSN3a/RSN3c #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/acceptance/rest/channels_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
let(:new_channel_options) { { encrypted: true } }
let(:original_channel) { client.channels.get(channel_name, options) }

it 'overrides the existing channel options and returns the channel object' do
it 'overrides the existing channel options and returns the channel object (RSN3c)' do
expect(original_channel.options).to_not include(:encrypted)
new_channel = client.channels.get(channel_name, new_channel_options)
expect(new_channel).to be_a(Ably::Rest::Channel)
Expand Down
6 changes: 3 additions & 3 deletions spec/unit/realtime/channels_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@

context 'creating channels' do
context '#get' do
it 'creates a channel if it does not exist' do
it 'creates a channel if it does not exist (RSN3a)' do
expect(Ably::Realtime::Channel).to receive(:new).with(client, channel_name, options)
subject.get(channel_name, options)
end

context 'when an existing channel exists' do
it 'will reuse a channel object if it exists' do
it 'will reuse a channel object if it exists (RSN3a)' do
channel = subject.get(channel_name, options)
expect(channel).to be_a(Ably::Realtime::Channel)
expect(subject.get(channel_name, options).object_id).to eql(channel.object_id)
end

it 'will update the options on the channel if provided' do
it 'will update the options on the channel if provided (RSN3c)' do
channel = subject.get(channel_name, options)
expect(channel.options).to eql(options)
expect(channel.options).to_not include(:encrypted)
Expand Down