Skip to content

Add support for RSA4b, b1, c, RSA16 (Authentication) #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
owenpearson merged 2 commits into from
Mar 4, 2022
Merged

Add support for RSA4b, b1, c, RSA16 (Authentication) #338

owenpearson merged 2 commits into from
Mar 4, 2022

Conversation

@ghost
Copy link

@ghost ghost commented Dec 20, 2021 •
edited by ghost
Loading

Resolves #268 #281

  • Using current time when checking token expiration (updated TokenDetails#expired? method by adding attributes and from option) RSA4b, RSA4b1
  • RSA16 is already implemented and tested as current_token_details

[#268] Resolves RSA4b1. Updated TokenDetails#expired?. Added :from at…
deda825 
…tribute and started using current_time when checking expiration and authorize for new token.
@ghost ghost self-assigned this Dec 20, 2021
@ghost ghost linked an issue Jan 10, 2022 that may be closed by this pull request
Write spec tests for RSA4b, b1, c, RSA16 (Authentication) #281
Closed
@ghost ghost marked this pull request as ready for review January 10, 2022 16:06
@ghost ghost requested a review from owenpearson January 10, 2022 16:06
owenpearson
owenpearson approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TheSmartnik
TheSmartnik reviewed Feb 14, 2022
View reviewed changes
TheSmartnik
TheSmartnik reviewed Feb 14, 2022
View reviewed changes
TheSmartnik
TheSmartnik reviewed Feb 14, 2022
View reviewed changes
@ghost ghost requested a review from TheSmartnik February 17, 2022 19:23
@QuintinWillison
Copy link
Contributor

QuintinWillison commented Mar 1, 2022

An approval from @TheSmartnik is going to carry much more value than one from me, so I'm going to remove my review request. There is a lot of background context to this change and the spec points referenced are borderline cryptic, so I would prefer to trust in those who are more actively working on this SDK to make the call as to whether this is ready to be merged.

@QuintinWillison QuintinWillison removed their request for review March 1, 2022 10:10
@owenpearson owenpearson merged commit 116ec0c into main Mar 4, 2022
@owenpearson owenpearson deleted the issue-268 branch March 4, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Write spec tests for RSA4b, b1, c, RSA16 (Authentication) Add support for RSA4b, b1, c, RSA16 (Authentication)

3 participants

@QuintinWillison @TheSmartnik @owenpearson