Skip to content

[EDX-282] Changed related to docstring, generate docs and CI workflow #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
owenpearson merged 70 commits into from
Sep 30, 2022
Merged

[EDX-282] Changed related to docstring, generate docs and CI workflow #376

owenpearson merged 70 commits into from
Sep 30, 2022

Conversation

@ghost
Copy link

@ghost ghost commented Sep 2, 2022 •
edited by ghost
Loading

@github-actions github-actions bot temporarily deployed to staging/pull/376/docs September 6, 2022 09:36 Inactive
Łukasz Śliwa added 27 commits September 12, 2022 16:49
Fix lib/ably/util/crypto.rb descriptions
4a0ed71
Fix lib/ably/rest/push/device_registrations.rb descriptions
2a41786
Fix lib/ably/rest/push/admin.rb descriptions
085a197
Fix lib/ably/rest/push.rb descriptions
b33fc8b
Fix lib/ably/rest/presence.rb descriptions
5167490
Fix lib/ably/rest/client.rb descriptions
fa9bdac
Fix lib/ably/rest/channels.rb descriptions
7e5f648
Fix lib/ably/rest/channel/push_channel.rb
239716d
Fix lib/ably/rest/channel.rb descriptions
5d40aa8
Fix lib/ably/realtime/push/admin.rb descriptions
a89e6a2
Fix lib/ably/realtime/push.rb descriptions
90af70d
Fix lib/ably/realtime/presence.rb descriptions
c838162
Fix lib/ably/realtime/connection/websocket_transport.rb descriptions
e750fe1
Fix lib/ably/realtime/connection/connection_manager.rb descriptions
93193d7
Fix lib/ably/realtime/connection.rb descriptions
9d7cd64
Fix lib/ably/realtime/client.rb descriptions
a25e6c5
Fix lib/ably/realtime/channels.rb descriptions
2914fb8
Fix lib/ably/realtime/channel/push_channel.rb descriptions
27b6a65
Fix lib/ably/realtime/channel/publisher.rb descriptions
f550994
Fix lib/ably/realtime/channel/channel_properties.rb descriptions
fe6941d
Fix lib/ably/realtime/channel.rb descriptions
601d03b
Fix lib/ably/modules/state_machine.rb descriptions
1f42cc0
Fix lib/ably/modules/state_emitter.rb descriptions
9cb72e8
Fix lib/ably/modules/model_common.rb descriptions
85c486b
Fix lib/ably/modules/event_emitter.rb descriptions
79d6c03
Fix lib/ably/modules/enum.rb descriptions
ab324bc
Fix lib/ably/modules/async_wrapper.rb descriptions
174a525
@github-actions github-actions bot temporarily deployed to staging/pull/376/docs September 12, 2022 15:14 Inactive
@ghost ghost marked this pull request as ready for review September 14, 2022 08:47
@jamienewcomb
Copy link
Member

jamienewcomb commented Sep 14, 2022

@owenpearson we just need a review on the ruby syntax here please :)

@jamienewcomb jamienewcomb assigned ghost Sep 14, 2022
owenpearson
owenpearson requested changes Sep 14, 2022
View reviewed changes
@ghost ghost requested a review from owenpearson September 20, 2022 15:55
owenpearson
owenpearson approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owenpearson owenpearson merged commit 9cb6d6b into main Sep 30, 2022
@owenpearson owenpearson deleted the edx-282 branch September 30, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jamienewcomb @owenpearson