[ECO-4767] Fix server certificate validation for HTTP in Realtime #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
force-pushed
the
396-internet-up-tls-error
branch
from
0ce1ca7 to
26d30e4
Compare
See ably-forks/em-http-request#2. This fixes the internet-up check and hence the fallback hosts mechanism. Resolves #396.
lawrence-forooghian
force-pushed
the
396-internet-up-tls-error
branch
from
26d30e4 to
48d4d9a
Compare
lawrence-forooghian
changed the title
lawrence-forooghian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #396.
(The tests pass when combined with @sacOO7’s WIP test fixes from #391; see #403.)