[ECO-4687][Protocol-2] Feature/resume recover #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntioning connection serial
related tests for the same
1. Set channelSerial when message, presencemessage or attached received 2. Send channelSerial while sending channel attach message 3. Set channelSerial to nil if channel is detached, failed or suspended
1. Retrieving value using create_recovery_key and setting msgserial, channel serials and recover key on connection 2. Handled resume/recover success/failure in connection manager. 3. Deprecated old recovery_key method on connection
This was referenced Jun 6, 2024
Collaborator
lawrence-forooghian
left a comment
lawrence-forooghian
left a comment
There was a problem hiding this comment.
Just to confirm — I think you previously mentioned that you’re going to fix tests and write new ones in a separate PR, is that right?
This reverts commit 21279fa.
Contributor
Author
This is done as a part of #411 |
lawrence-forooghian
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Protocol 2, also calledno-connection-serialliterally means removing all references ofconnection_serialfrom the code.