Skip to content

Fix RSA7a clientId #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sacOO7 merged 3 commits into from
Jul 8, 2024
Merged

Fix RSA7a clientId #428

sacOO7 merged 3 commits into from
Jul 8, 2024

Conversation

@sacOO7
Copy link
Contributor

@sacOO7 sacOO7 commented Jul 5, 2024 •
edited
Loading

@github-actions github-actions bot temporarily deployed to staging/pull/428/docs July 5, 2024 17:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/428/features July 5, 2024 17:18 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review July 5, 2024 17:32
@sacOO7 sacOO7 requested review from AndyTWF, SimonWoolf and ttypic July 5, 2024 17:33
ttypic
ttypic approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sacOO7 sacOO7 merged commit e37a725 into main Jul 8, 2024
@sacOO7 sacOO7 deleted the fix/RSA7a-clientId branch July 8, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttypic ttypic ttypic approved these changes

@AndyTWF AndyTWF Awaiting requested review from AndyTWF

@SimonWoolf SimonWoolf Awaiting requested review from SimonWoolf

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix tests based on more clarification on RSA7e

3 participants

@sacOO7 @ttypic