Skip to content

Live objects: Add REST API docs#2490

Merged
zknill merged 1 commit intointegration/liveobjectsfrom
zak/pub-1040/rest-api-reference-docs
Apr 2, 2025
Merged

Live objects: Add REST API docs#2490
zknill merged 1 commit intointegration/liveobjectsfrom
zak/pub-1040/rest-api-reference-docs

Conversation

@zknill
Copy link
Contributor

@zknill zknill commented Mar 24, 2025

Description

Add new page in the "API References" part of the product docs which details the REST APIs available for interacting with live objects.

Checklist

@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ably-ci ably-ci temporarily deployed to ably-docs-zak-pub-1040--zsi0bp March 24, 2025 12:04 Inactive
@zknill zknill force-pushed the zak/pub-1040/rest-api-reference-docs branch from 0acd63d to c585d8f Compare March 24, 2025 12:04
@VeskeR VeskeR force-pushed the liveobjects-navigation branch 2 times, most recently from a9b4071 to 6d37df9 Compare March 25, 2025 07:26
@zknill zknill force-pushed the zak/pub-1040/rest-api-reference-docs branch from c585d8f to 4f2c343 Compare March 25, 2025 09:54
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting some review comments I had while updating the REST API on the client.
Apologies if I jumped the gun on any of them - I realize this PR is still in draft.

"operation": "MAP_CREATE",
"data": {
"myMapKey": {"data": {"string": "myMapValue"}},
"myOtherKey": {"data": {"boolean": true}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was the reasoning to make the map create operation explicitly state the type of the value for a key:
{"string": "myMapValue"}, {"boolean": true},
as opposed to a bit simpler previous format:
{"value": "myMapValue"}, {"value": true} and to disambiguate objectIds: {"objectId": "counter:Nz1ZiNjqsDfkDjA61xarinqpWsqEGAAw2mzWWtvX2b8@1742481614000"} ?

the latter is slightly easier to use as it's just always "value", unless it's a reference to another object.

is this mainly to maintain parity with the data values returned in the List API responses?

{ "data": { "number" : 4 }}
{ "data": { "string" : "Ably Pub/Sub" }}
{ "data": { "boolean" : true }}
{ "data": { "bytes": "TGl2ZU9iamVjdHMgaXMgYXdlc29tZQo=", "encoding": "base64" }}
{ "data": { "objectId": "counter:Nz1ZiNjqsDfkDjA61xarinqpWsqEGAAw2mzWWtvX2b8@1742481614000" }}

@zknill zknill force-pushed the zak/pub-1040/rest-api-reference-docs branch 3 times, most recently from cfc1048 to f207d5d Compare March 28, 2025 15:37
@zknill zknill requested a review from VeskeR March 28, 2025 15:37
@zknill zknill force-pushed the zak/pub-1040/rest-api-reference-docs branch from f207d5d to 9992e40 Compare March 31, 2025 09:44
@zknill zknill requested a review from VeskeR March 31, 2025 10:38
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one last minor comment to remove the use of "state"

Add new page in the "API References" part of the product docs which
details the REST APIs available for interacting with live objects.
@zknill zknill force-pushed the zak/pub-1040/rest-api-reference-docs branch from 9992e40 to fab36af Compare April 1, 2025 08:47
Base automatically changed from liveobjects-navigation to integration/liveobjects April 2, 2025 07:18
@zknill zknill marked this pull request as ready for review April 2, 2025 09:18
@zknill zknill merged commit a22eae2 into integration/liveobjects Apr 2, 2025
5 checks passed
@zknill zknill deleted the zak/pub-1040/rest-api-reference-docs branch April 2, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants