Add RTP17b for my-members presencemap definition fix #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client clearly shouldn't remove an entry from the internal map (of members to be re-entered after a resume/recover) based on the synthesized leave realtime sends on-dormant, that defeats the point. We knew about this requirement back in 2016 because I implemented it in ably-js, but apparently I neglected to add it to the spec at the time -- my bad.
Adding now as a requirement for the 1.1 spec so realtime can assume any client that sends v=1.1 can take responsibility for keeping its own members in presence, cf fourth bullet point of https://github.com/ably/realtime/issues/1786.