Move object checks to class constructors #27 #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also fixed five failing tests. Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Refactor DeltaCode, Delta, Scan and File constructors and related
methods.
* Fix failing tests, add several new tests.
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
* Merging updated 'develop' into local 27 before pushing.
steven-esser
reviewed
Dec 7, 2017
src/deltacode/__init__.py
Outdated
| 'added', 'modified', 'removed' or 'unmodified'. | ||
| """ | ||
| def __init__(self, new_file=None, old_file=None, delta_type=None): | ||
| # TODO: add check to ensure both are File objects |
Contributor
There was a problem hiding this comment.
We can remove this TODO
Contributor
|
Looks good, other than 1 minor correction. |
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Jono Yang <jyang@nexb.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
* Create copyright statement from holder information Signed-off-by: Jono Yang <jyang@nexb.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
* This is used for the case where we are starting off a project and have not yet generated requirements files Signed-off-by: Jono Yang <jyang@nexb.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Jono Yang <jyang@nexb.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
* Add --init option to configure.bat
* Update help text in configure and configure.bat
Signed-off-by: Jono Yang <jyang@nexb.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Jono Yang <jyang@nexb.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Jono Yang <jyang@nexb.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
* Update README.rst Signed-off-by: Jono Yang <jyang@nexb.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
* Update README.rst with instructions for post-initialization usage Signed-off-by: Jono Yang <jyang@nexb.com>
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
* Replace references to scancode-toolkit repo with links to the skeleton repo
* Remove --python option from configure.bat
Signed-off-by: Jono Yang <jyang@nexb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeltaCode,Delta,ScanandFileconstructors and related methods.Signed-off-by: John M. Horan johnmhoran@gmail.com