Increment determine_delta() counter #28 #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
steven-esser
suggested changes
Dec 7, 2017
src/deltacode/__init__.py
Outdated
| assert new_files_to_visit == 0 | ||
| assert old_files_to_visit == 0 | ||
| assert new_files_visited == self.new.files_count | ||
| assert old_files_visited == self.old.files_count |
Contributor
There was a problem hiding this comment.
For these assertion statements, we should add some custom text to make the assertion more clear. For example:
assert type(name) is StringType, "name is not a string: %r" % name
In this case "name is not a string: name" is printed if the data type of name is not a string.
We can adapt this to our code here by doing something like:
assert new_files_visited == self.new.files_count, "Number of visited files({})) does not match total_files({}) in the new scan".format(new_visited_files, self.new.files_count)
Member
Author
There was a problem hiding this comment.
Nice idea. Coming shortly...
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
steven-esser
approved these changes
Dec 8, 2017
arnav-mandal1234
pushed a commit
to arnav-mandal1234/deltacode
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Jono Yang <jyang@nexb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John M. Horan johnmhoran@gmail.com