Parse expressions with nested license names and spaces#31
Parse expressions with nested license names and spaces#31pombredanne merged 9 commits intomasterfrom
Conversation
This is just the tests for now, to support alternative implementation Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
These can include spaces or not. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Cleanup Licensing.tokenize() Also refactor code to move tokenizing stages in their own functions Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
Note that the changes are quite extensive because of some renaming for clarity.
As a side note, the travis config has been fixed such that tests now run OK on all OSes and Python versions |
tdruez
left a comment
There was a problem hiding this comment.
@pombredanne the changes looks good. Thanks for all the extra unit tests.
My only concern is about the if TRACE: placed a bit everywhere.
This seems to duplicate the logic of the logging setup module. Minor in any cases.
|
@tdruez in reply to:
We do not need this tracing anymore ... so let me remove this. |
Also update boolean.py to 3.6 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
5c5b281 to
ccfe96b
Compare
|
@tdruez in reply to:
We do not need this tracing anymore ... so let me remove this. I pushed a version without this and will merge shortly |
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Check for deps in local thirdparty directory #31
This is a fix for the #29 bug