Conversation
a44c4ab to
f8a0c93
Compare
pombredanne
left a comment
There was a problem hiding this comment.
Thank you!. See my comment inline
tests/test_license_expression.py
Outdated
|
|
||
| expr = licensing.parse('gpl-2.0 OR apache-2.0 OR gpl-2.0') | ||
|
|
||
| self.assertEqual(expr.simplify(), expr.simplify(sort=False)) |
There was a problem hiding this comment.
with gpl-2.0 OR apache-2.0 OR gpl-2.0 I would expect the simplification to be gpl-2.0 OR apache-2.0 ... would you?
Also a small nitpicking: may be we do not need so many empty lines?
There was a problem hiding this comment.
This is checking to make sure the expressions themselves are equal, even if the "sort" of the expression is different.
For instance mit OR gpl-2.0 === gpl-2.0 OR mit. These expressions are technically the same data-wise and interpretation-wise. The only difference between the two expressions is the ordering, which the following test on line 560 handles.
The test itself is actually not super clear as to what is going on, so I will update this.
There was a problem hiding this comment.
@pombredanne and we probably do not need so many lines, I will fix this :)
* Bump boolean.py library to v3.7, which adds the ability to sort OR leave boolean expressions unsorted. * Add test case for simplify() sorting Addresses: #32 Signed-off-by: Steven Esser <sesser@nexb.com>
f8a0c93 to
2ab7b77
Compare
* Update test case code for clarity * Remove un-needed blank lines * Update Windows azure pipeline to use python3.7.4 Addresses: #32 Signed-off-by: Steven Esser <sesser@nexb.com>
|
@pombredanne ping the travis builds are timing-out for some unknown reason. |
|
I have restarted the builds |
|
there might be something wrong with the following lines in travis on osx that are causing it to hang: Do we need to use pyenv for these?: |
No. Anything works and if you look at the latest travis from scancode, this is quite different now |
Signed-off-by: Steven Esser <sesser@nexb.com>
|
@pombredanne Everything is working now. |
|
Thank you! LGTM... merging. |
|
@MaJuRG what is you Pypi username? I will grant you access to make a release |
Signed-off-by: Chin Yeung Li <tli@nexb.com>
Fixed #41 - Handled encoding issue when generating ABOUT files
leave boolean expressions unsorted.
Addresses: #32
Signed-off-by: Steven Esser sesser@nexb.com