Make WITH expressions more readable #45#46
Merged
steven-esser merged 7 commits intomasterfrom Nov 15, 2019
Merged
Conversation
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This add a new render_as_readable() function that will wrap the WITH expression in parens (unless this is only a simple WITH expression) Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Python 3.8 emits a SyntaxWarning for a string with an anomalous backslash, e.g.: <unknown>:127: SyntaxWarning: invalid escape sequence \s Fix by adding the missing 'r' prefix. Change-Id: If9ad77c1e1707fa2432c8fc31eeb5e6d2d7200a5 Signed-off-by: Peter Kolbus <peter.kolbus@garmin.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Contributor
steven-esser
left a comment
steven-esser
left a comment
There was a problem hiding this comment.
LGTM, other than the small doc correction.
src/license_expression/__init__.py
Outdated
| def render(self, template='{symbol.key}', *args, **kwargs): | ||
| def render(self, template='{symbol.key}', wrap_with_in_parens=False, *args, **kwargs): | ||
| """ | ||
| Return a formatted WITH expression. If `wrap_in_parens`, wrap in parens. |
Contributor
There was a problem hiding this comment.
I think wrap_in_parens should be wrap_with_in_parens to correctly mirror the argument name.
Member
Author
There was a problem hiding this comment.
I pushed a commit to fix this.
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reported-by: Steven Esser <sesser@nexb.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
45-more-readable-expressions
branch
from
2899cd4 to
651c48d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a solution for #45