Skip to content

Simplify programming language reporting#1201

Merged
pombredanne merged 4 commits intodevelopfrom
1194-programming-language
Oct 19, 2018
Merged

Simplify programming language reporting#1201
pombredanne merged 4 commits intodevelopfrom
1194-programming-language

Conversation

@pombredanne
Copy link
Member

@pombredanne pombredanne commented Oct 8, 2018

This PR deals with #1194 to only report real programming languages.

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

@pombredanne pombredanne force-pushed the 1194-programming-language branch from 2dbe8d4 to d8f3972 Compare October 16, 2018 23:33
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This disables several Pygments lexers and updates the tests
accordingly

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne force-pushed the 1194-programming-language branch from bad3002 to b88086e Compare October 17, 2018 01:38
@codecov
Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #1201 into develop will decrease coverage by 0.39%.
The diff coverage is 56.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #1201     +/-   ##
==========================================
- Coverage    83.12%   82.72%   -0.4%     
==========================================
  Files          115      117      +2     
  Lines        12741    12888    +147     
==========================================
+ Hits         10591    10662     +71     
- Misses        2150     2226     +76
Impacted Files Coverage Δ
src/typecode/prog_lexers.py 100% <100%> (ø)
src/typecode/contenttype.py 85.88% <100%> (-0.47%) ⬇️
src/typecode/pygments_lexers.py 52.25% <52.25%> (ø)
src/scancode/api.py 93.47% <0%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cda8e9...b88086e. Read the comment docs.

@pombredanne
Copy link
Member Author

This can be a tad controversial as it changes which programming languages and what file types are returned. Nevertheless this is a much welcomed simplification in practice as this was a rather annoying bug-like data issue until now: merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant