Migrate apache httpd importer#971 #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmhoran
force-pushed
the
971-migrate-apache-httpd-importer
branch
from
07ad467 to
49b51c8
Compare
TG1999
reviewed
Dec 7, 2022
pombredanne
requested changes
Dec 13, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks! here are a few nitpickings for your consideration
Member
Author
|
Thanks @pombredanne . @TG1999 -- would you like me to make the changes @pombredanne has suggested and push my updated code before you start your review, or shall I wait for your comments? |
Contributor
|
@johnmhoran please address @pombredanne review comments and push the updated code. |
Member
Author
|
Thank you @TG1999 -- will do. |
pombredanne
requested changes
Dec 24, 2022
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
LGTM! Thanks. We just need a CHANGELOG entry
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
…ted_package Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
johnmhoran
changed the title
Closed
johnmhoran
force-pushed
the
971-migrate-apache-httpd-importer
branch
from
a49f502 to
0b74c9f
Compare
johnmhoran
changed the title
Reference: #971 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
TG1999
requested changes
Jan 6, 2023
vulnerabilities/tests/test_data/apache_httpd/CVE-2021-44224-apache-httpd-expected.json
Outdated
Show resolved
Hide resolved
vulnerabilities/tests/test_data/apache_httpd/CVE-2021-44224-apache-httpd-expected.json
Outdated
Show resolved
Hide resolved
vulnerabilities/tests/test_data/apache_httpd/CVE-2022-28614-apache-httpd-expected.json
Outdated
Show resolved
Hide resolved
vulnerabilities/tests/test_data/apache_httpd/CVE-2022-28614-apache-httpd-expected.json
Outdated
Show resolved
Hide resolved
vulnerabilities/tests/test_data/apache_httpd/CVE-2022-28614-apache-httpd-expected.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to Issue #971.