-
-
Notifications
You must be signed in to change notification settings - Fork 268
[For Review Purpose Only-Do not Merge] First Draft for Glibc Importer #1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TG1999
requested changes
Feb 12, 2024
Contributor
TG1999
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits as per my initial review
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
7a282af to
1a1ffa8
Compare
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Contributor
Author
|
First draft for importer published. |
Contributor
|
@harsh098 closing this PR, feel free to open this once it's ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1362.
Parser has been added in order to review the parser for GLIBC Importer.
@TG1999 and @pombredanne please have a look.