Fix and renable safetydb importer #273
Conversation
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
This looks fine but we cannot have this enabled by default license-wise for now. How could we have a way to enable this on demand?
| # 'etags': {} | ||
| # }, | ||
| # }, | ||
| { |
There was a problem hiding this comment.
We need to have a way to selectively enable some non-free resources like this one. As long as this is under a cc-by-nc license we cannot integrate these data by default IMHO
@jayfk ping?
|
@pombredanne from the discussion we had, you suggested we handle this by using a config file which contains a list of licenses. I think this logic belongs in the |
| 'url': 'https://raw.githubusercontent.com/pyupio/safety-db/master/data/insecure_full.json', # nopep8 | ||
| 'etags': {} | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Let's add instead a flag to disable this rather than commenting it out and leave this disabled.
|
Commits included in #259. Hence closing |
2 participants
Fixes #244
Signed-off-by: Shivam Sandbhor shivam.sandbhor@gmail.com