Skip to content

Add tests to check upstream data #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbs2001 merged 2 commits into from
Apr 4, 2021
Merged

Add tests to check upstream data #365

sbs2001 merged 2 commits into from
Apr 4, 2021

Conversation

@sbs2001
Copy link
Collaborator

@sbs2001 sbs2001 commented Mar 2, 2021

Signed-off-by: Shivam Sandbhor shivam.sandbhor@gmail.com

@sbs2001 sbs2001 changed the title Add tests to check upstream data [WIP]Add tests to check upstream data Mar 2, 2021
@sbs2001 sbs2001 force-pushed the test_upstream_data branch from 693d564 to 8993111 Compare March 4, 2021 11:31
@sbs2001
Copy link
Collaborator Author

sbs2001 commented Mar 12, 2021

Part of #272 effort

@sbs2001 sbs2001 force-pushed the test_upstream_data branch 2 times, most recently from 5c313bb to 8c805cf Compare March 13, 2021 06:34
@sbs2001 sbs2001 changed the title [WIP]Add tests to check upstream data Add tests to check upstream data Mar 13, 2021
@sbs2001
Copy link
Collaborator Author

sbs2001 commented Mar 13, 2021

@rolfschr this pr is adding a test for upstream data sources. The nix pipeline is running this test, could you disable that.

I think at https://github.com/nexB/vulnerablecode/blob/d8ce30e29c0d3257a1d00d89feb0afa753ba3f69/etc/nix/flake.nix#L139
instead of just running pytest, running pytest -m "not webtest" would fix this. Not sure whether this has any side effets tho.

@rolfschr rolfschr mentioned this pull request Mar 13, 2021
Merged
@sbs2001 sbs2001 force-pushed the test_upstream_data branch 2 times, most recently from 5a95b97 to 58461c0 Compare March 19, 2021 09:18
@sbs2001 sbs2001 requested a review from pombredanne March 19, 2021 09:21
@sbs2001 sbs2001 mentioned this pull request Apr 1, 2021
Closed
sbs2001 added 2 commits April 2, 2021 15:06
@sbs2001
Add tests for checking upstream data sources
e0bd0f0 
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
@sbs2001
Update travis config
60370ee 
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
@sbs2001 sbs2001 force-pushed the test_upstream_data branch from b4a219c to 60370ee Compare April 2, 2021 09:37
@sbs2001 sbs2001 merged commit 86424ee into aboutcode-org:main Apr 4, 2021
@Hritik14 Hritik14 mentioned this pull request Apr 4, 2021
Closed
@sbs2001 sbs2001 mentioned this pull request Apr 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredanne pombredanne Awaiting requested review from pombredanne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sbs2001