Sanity Checks for redhat import response#387
Merged
sbs2001 merged 1 commit intoaboutcode-org:mainfrom Mar 19, 2021
Merged
Conversation
savish28
force-pushed
the
Issue#384
branch
3 times, most recently
from
ae4f9dd to
67f420c
Compare
Contributor
Author
|
@sbs2001 PR up for review! |
sbs2001
requested changes
Mar 18, 2021
vulnerabilities/importers/redhat.py
Outdated
| value=bugzilla_severity_val, | ||
| ) | ||
| if ( | ||
| ("bugs" in bugzilla_data) |
Collaborator
There was a problem hiding this comment.
this could be made more concise by using bugzilla_data.get("bugs")
vulnerabilities/importers/redhat.py
Outdated
| if ( | ||
| ("bugs" in bugzilla_data) | ||
| and len(bugzilla_data["bugs"]) | ||
| and ("severity" in bugzilla_data["bugs"][0]) |
Collaborator
There was a problem hiding this comment.
this could be made more concise by using bugzilla_data.get["bugs"][0].get("severity")
Signed-off-by: savish <savishbedi1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Fix: #384.
Added Sanity checks for RedHat import failing.